Re: [PATCH] sparse, llvm: More comparison ops code generation

[Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>]

On Tue, Nov 22, 2011 at 9:40 AM, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
> This patch implements LLVM code generation for OP_SET_LE, OP_SET_GE, OP_SET_BE,
> and OP_SET_AE.

Ugh.

Can't you just do it with a single statement like

    target = LLVMBuildICmp(fn->builder, translate_op(op), lhs, rhs,
target_name);

instead of having that case-statement where every case does the same thing?

The translate_op() thing should be trivial too, just something like

   static int translate_op(int sparse_op)
   {
       static const int trans_tbl[] = {
           .[OP_SET_LE] = LLVMIntSLE,
       ...
        };
        return trans_tbl[sparse_op];
   }

or whatever. No?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html