Hi Geert, On Fri, Apr 11, 2014 at 4:28 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Magnus, > > On Tue, Apr 8, 2014 at 2:48 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: >> +++ work/arch/arm/mach-shmobile/platsmp-apmu.c 2014-04-08 19:01:55.000000000 +0900 >> @@ -18,6 +18,19 @@ >> #include <asm/smp_plat.h> >> #include <mach/common.h> >> >> +/* only enable the cluster that includes the boot CPU by default */ >> +static bool enable_multicluster = false; >> + >> +static __init int apmu_setup(char *opt) >> +{ >> + if (!opt) >> + return -EINVAL; >> + if (!strncmp(opt, "multicluster", 12)) > > Why do you ignore the characters after "multicluster", i.e. why not > simply "!strcmp(opt, "multicluster)"? Good point, thanks. >> + enable_multicluster = true; >> + return 0; >> +} >> +early_param("apmu", apmu_setup); > > This can use some documentation under Documentation/. If this was destined for upstream merge I totally agree, but in this particular case it is just prototype-level code. The proper solution involves upstream scheduler modifications and perhaps also MCPM once we care about cluster-level power management. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html