Re: [PATCH][RFC] ARM: mach-shmobile: setup-sh7372: fixup chclr_offset base

[Guennadi Liakhovetski <g.liakhovetski@xxxxxx>]

On Wed, 30 May 2012, Kuninori Morimoto wrote:

> Hi Guennadi
> 
> > > Thanks.
> > > But sorry. I didn't have any problem.
> > > I noticed it from source-code only, not board behavior.
> > 
> > Ok, but did you at least run some tests, where this code-path would be 
> > entered, including (runtime-) suspend and resume? If not yet, I think, it 
> > would be good to at least run a couple of short tests to make sure we're 
> > not causing any obvious regressions. I'll try to find some time later 
> > today or tomorrow for this.
> 
> Yes. of course I tested my patch on FSI DMAEngine.
> In my test, I didn't get any issue with/without this patch.
> 
> I double-checked this issue, but sh7372 has offset bug.
> This is the reason why I added [RFC] on this patch.

I tested a 9-day old next tree with and without your patch with 
runtime-suspend - both when the A3SP domain stays on and when it gets 
switched off - both versions seem to work, so, at least I don't recognise 
any regressions. Unfortunately, I couldn't test system-wide suspend 
because of some NFS problem. So, you can also add a (partially-)

Tested-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html