Re: [PATCH 7/8] irqdomain: trivial pr_fmt conversion.

[Joe Perches <joe@xxxxxxxxxxx>]

On Sat, 2012-05-19 at 15:11 +0900, Paul Mundt wrote:
> Convert to pr_fmt before things start to get out of hand and some
> janitors start getting overly excited.

;)  OK then, here's some trivia:

> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
[]
> @@ -1,3 +1,5 @@
> +#define pr_fmt(fmt)  "irq: " fmt

"irqdomain: " (KBUILD_MODNAME) may be more sensible

[]
> @@ -410,23 +412,23 @@ unsigned int irq_create_mapping(struct irq_domain *domain,
>  	unsigned int hint;
>  	int virq;
>  
> -	pr_debug("irq: irq_create_mapping(0x%p, 0x%lx)\n", domain, hwirq);
> +	pr_debug("irq_create_mapping(0x%p, 0x%lx)\n", domain, hwirq);

"%s: ...", __func__, etc...

>  	if (domain == NULL) {
> -		printk(KERN_WARNING "irq_create_mapping called for"
> -		       " NULL domain, hwirq=%lx\n", hwirq);
> +		pr_warning("irq_create_mapping called for"
> +			   " NULL domain, hwirq=%lx\n", hwirq);

		pr_warn("%s: called with NULL domain, hwirq=%lx\n", hwirq);

> @@ -522,8 +524,8 @@ unsigned int irq_create_of_mapping(struct device_node *controller,
>  		if (intsize > 0)
>  			return intspec[0];
>  #endif
> -		printk(KERN_WARNING "irq: no irq domain found for %s !\n",
> -		       controller->full_name);
> +		pr_warning("no irq domain found for %s !\n",
> +			   controller->full_name);

		pr_warn(...)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html