Re: [PATCH v2] serial: sh-sci: modify sci_break_ctl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Apr 06, 2012 at 12:50:00PM +0900, Shimoda, Yoshihiro wrote:
> 2012/04/06 11:44, Simon Horman wrote:
> > On Fri, Apr 06, 2012 at 11:13:24AM +0900, Shimoda, Yoshihiro wrote:
> >>
> >> Thank you for the check.
> >> setup-xxxx.c which have "PORT_SCIF" can be tested:
> >>  - SH7724, SH7785, R8A7779, etc.
> > 
> > Thanks, I will try and test on ecovec which I believe has SH7724.
> 
> Yes, ecovec has SH7724.
> 
> > Do you have any information on how I should test the code,
> > other than booting it
> 
> If userland calls ioctl with TIOCSBRK/TIOCCBRK, the sci_break_ctl
> is called. After TIOCSBRK we cannot send data from SCIF.
> After TIOCCBRK, we can send data from SCIF.

Thanks, that make a lot of sense.

Unfortunately the ecovec doesn't exercise the new code
as the regtype of its scif is SCIx_SH4_SCIF_NO_SCSPTR_REGTYPE
but your code only operates on SCIx_SH4_SCIF_REGTYPE.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux OMAP]     [Linux USB Devel]     [Linux ARM Kernel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [X.Org]

Add to Google Powered by Linux