- Subject: Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes
- From: Richard Weinberger <richard@xxxxxx>
- Date: Sat, 24 Mar 2012 12:12:40 +0100
- Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Mike Frysinger <vapier@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mundt <lethal@xxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>, John Stultz <john.stultz@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
- In-reply-to: <20120324103030.GG29067@lizard>
- References: <20120324102609.GA28356@lizard> <20120324103030.GG29067@lizard>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0
Am 24.03.2012 11:30, schrieb Anton Vorontsov:
> Traversing the tasks requires holding tasklist_lock, otherwise it
> is unsafe.
>
> p.s. However, I'm not sure that calling os_kill_ptraced_process()
> in the atomic context is correct. It seem to work, but please
> take a closer look.
os_kill_ptraced_process() calls a host function.
From UML's point of view nothing sleeps, so this is fine.
Acked-by: Richard Weinberger <richard@xxxxxx>
Thanks,
//richard
Attachment:
signature.asc
Description: OpenPGP digital signature
[Linux OMAP]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]