Re: [PATCH] drivers/tty/tty_io.c: fix a potential memleak at do_tty_write()

[Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>]

On Mon, 18 Jun 2012 20:23:54 +0800
Jeff Liu <jeff.liu@xxxxxxxxxx> wrote:

> Hello,
> 
> Looks there is a potential memory leak at drivers/tty/tty_io.c: do_tty_write().
> It did allocate a buf_chunk if tty->write_cnt < chunk, however, buf_chunk was not
> freed after the writing is done.  Below tiny patch could fix it.

Why should it be freed, we still have a reference to it.


Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html