Re: [PATCH v3] serial: PL011: clear pending interrupts

[viresh kumar <viresh.linux@xxxxxxxxx>]

On Tue, Mar 13, 2012 at 5:57 PM, Linus Walleij
<linus.walleij@xxxxxxxxxxxxxx> wrote:
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> @@ -1927,6 +1930,10 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
>                goto unmap;
>        }
>
> +       /* Ensure interrupts from this UART are masked and cleared */
> +       writew(0, uap->port.membase + UART011_IMSC);
> +       writew(0xffff, uap->port.membase + UART011_ICR);
> +


Hey Linus,

I was working on v3.3 and found a crash for my SoC. When i checked i got a crash
due to above changes.

There are two issues here
 - uap->port is uninitialized
 - clk is not enabled.

How is this working for you?

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html