Re: [PATCH] sctp: Do not account for sizeof(struct sk_buff) in estimated rwnd
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 12/20/2011 04:39 AM, Thomas Graf wrote:
On Tue, Dec 20, 2011 at 01:00:48PM +0800, Wei Yongjun wrote:I saw you discussed this with Vlad in old mail: http://www.spinics.net/lists/linux-sctp/msg01365.html You said you will update patch to include a per packet overhead, but it does not include in this patch, what's wrong with in?It's not possible because upon retransmission of a chunk we need to readd the overhead to the rwnd. There is no longer a reference to a packet so we can't know how much to add. This explanation is also in the original mail thread.
Right. The original patches were done to work around the problem of leftover rwnd when socket buffer is exhausted and they didn't really address the problem sufficiently. It was still possible to reach that condition. Some subsequent patches added support to address this issue a different way. As a result, I think this revert is just fine. Acked-by: Vlad Yasevich <vladislav.yasevich@xxxxxx> -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html