|
|
|
Re: [PATCH 2/3] sctp: export SctpT1Retransmits to /proc/net/sctp/snmp | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
Hi
Shan Wei wrote:
> SctpT1Retransmits is defined and counted, but is not exported
> to snmp file.
>
> We don't know if any user applications read this snmp file, so
> we add it to he end of snmp file. This seems be more safe than
> exporting it according to the definition in order.
>
>
> Signed-off-by: Shan Wei <shanwei@xxxxxxxxxxxxxx>
> ---
> net/sctp/proc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 61aacfb..5584d1a 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -73,6 +73,7 @@ static const struct snmp_mib sctp_snmp_list[] = {
> SNMP_MIB_ITEM("SctpInPktBacklog", SCTP_MIB_IN_PKT_BACKLOG),
> SNMP_MIB_ITEM("SctpInPktDiscards", SCTP_MIB_IN_PKT_DISCARDS),
> SNMP_MIB_ITEM("SctpInDataChunkDiscards", SCTP_MIB_IN_DATA_CHUNK_DISCARDS),
> + SNMP_MIB_ITEM("SctpT1Retransmits", SCTP_MIB_T1_RETRANSMITS),
> SNMP_MIB_SENTINEL
> };
>
Why do you need that when we already have SctpT1InitExpireds and
SctpT1CookieExpireds. Just sum them together and you get the
the T1_RETRANSMITS.
-vlad
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
|