Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

[Mike Christie <michaelc@xxxxxxxxxxx>]

On 08/13/2012 06:59 AM, Masatake YAMATO wrote:
> In iscsi_free_task, NULL is assigned to task->sc twice: before and
> after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded
> with session->lock, so multiple NULL assignments cause no trouble. But
> people reading the source code may be confused.
> 
> The second NULL assignment comes from commit:
> 
>     3e5c28ad0391389959ccae81c938c7533efb3490
> 
> It seems that the line after kfifo_in invocation was introduced
> accidentally.
> 
> Signed-off-by: Masatake YAMATO <yamato@xxxxxxxxxx>
> Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>

Thanks for resending to the linux-scsi list and picking up my reviewed
by line. Looks ok to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html