Re: scsi_requeue_command and dropping reference to sdev_gendev

[James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>]

On Mon, 2012-07-23 at 21:13 -0700, Ani Sinha wrote:
> Hi :
> 
> I am looking at the latest upstream code and I see a potential issue :
> 
> - scsi_requeue_command() drops reference to scsi_device->sdev_gendev in
> scsi_unprep_request->scsi_put_command()->__scsi_put_command(). This can
> trigger the cleanup routine scsi_device_dev_release_usercontext() that
> will deallocate the sdev->request_queue in blk_put_queue() call. This can
> cause potential problems in scsi_requeue_command() when it calls
> scsi_run_queue().
> 
> Am I missing something here?
> 
> Any suggestion will be greatly appreciated.

commit 940f5d47e2f2e1fa00443921a0abf4822335b54d
Author: Bart Van Assche <bvanassche@xxxxxxx>
Date:   Fri Jun 29 15:34:26 2012 +0000

    [SCSI] Avoid dangling pointer in scsi_requeue_command()

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html