Re: [PATCH] bnx2i: fix the bit manipulation when setting the error mask

["Eddie Wai" <eddie.wai@xxxxxxxxxxxx>]

On Tue, 2012-07-03 at 10:08 +0200, Tomas Henzl wrote:
> The intention in bnx2i_send_fw_iscsi_init_msg was to zero out
> only the lower 32bits, but instead the whole mask64 is zeroed.
> This patch fixes it.
> 
> Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> ---
> diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
> index ece47e5..1cbf402 100644
> --- a/drivers/scsi/bnx2i/bnx2i_hwi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
> @@ -1314,7 +1314,7 @@ int bnx2i_send_fw_iscsi_init_msg(struct bnx2i_hba *hba)
>  		(1ULL << ISCSI_KCQE_COMPLETION_STATUS_PROTOCOL_ERR_LUN));
>  	if (error_mask1) {
>  		iscsi_init2.error_bit_map[0] = error_mask1;
> -		mask64 &= (u32)(~mask64);
> +		mask64 ^= (u32)(mask64);
>  		mask64 |= error_mask1;
>  	} else
>  		iscsi_init2.error_bit_map[0] = (u32) mask64;
> 
> 
> 
Looks good.  Thanks.

Acked-by: Eddie Wai <eddie.wai@xxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html