Re: lpfc: problems with -Werror

[James Bottomley <jbottomley@xxxxxxxxxxxxx>]

On Thu, 2012-06-21 at 09:30 +0800, Fengguang Wu wrote:
> Hi Alex,
> 
> In commit d438bd3aef ("Add -Werror compilation flag") you added this:
> 
> +ccflags-y += -Werror
> 
> Now I run into a number of gcc errors when running randconfig tests.
> They smell like false warnings. I don't quite understand why you made
> that "-Werror" conditional and only fail on CONFIG_SCSI_LPFC=y.  But
> if you prefer to keep that -Werror, I'll send a (perhaps silly) patch
> to quiet these error messages.

They're all bogus, but we can't really have the build break because gcc
is fragile.

James and Alex, how about this: It's the aic7xxx solution: it allows you
to build the kernel with make WARNINGS_BECOME_ERRORS=1 to get -Werror
but it's not on by default?

James

---

diff --git a/drivers/scsi/lpfc/Makefile b/drivers/scsi/lpfc/Makefile
index fe5d396..e2516ba 100644
--- a/drivers/scsi/lpfc/Makefile
+++ b/drivers/scsi/lpfc/Makefile
@@ -22,7 +22,9 @@
 ccflags-$(GCOV) := -fprofile-arcs -ftest-coverage
 ccflags-$(GCOV) += -O0
 
+ifdef WARNINGS_BECOME_ERRORS
 ccflags-y += -Werror
+endif
 
 obj-$(CONFIG_SCSI_LPFC) := lpfc.o
 

��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f