Re: [scsi:pending 3/3] drivers/scsi/aacraid/src.c:425:2: warning: right shift count >= width of type

[Ben Collins <benmcollins13@xxxxxxxxx>]

On Jun 20, 2012, at 12:44 PM, Ben Collins wrote:

> On Jun 20, 2012, at 12:12 PM, wfg@xxxxxxxxxxxxxxx wrote:
> 
>> Hi Ben,
>> 
>> There are new compile warnings show up in
>> 
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git pending
>> head:   e766db42f45c7685fce5c0d48ba74eaa97e6d715
>> commit: e766db42f45c7685fce5c0d48ba74eaa97e6d715 [3/3] [SCSI] aacraid: Fix endian issues in core and SRC portions of driver
>> 
>> All warnings:
>> 
>> drivers/scsi/aacraid/src.c: In function 'aac_src_deliver_message':
>> drivers/scsi/aacraid/src.c:425:2: warning: right shift count >= width of type [enabled by default]
> 
> Hrmm, pretty innocuous, but I guess it could be rewritten as:
> 
> #if BITS_PER_LONG > 32
>         src_writel(dev, MUnit.IQ_H, (address >> 32) & 0xffffffff);
> #else
>         src_writel(dev, MUnit.IQ_H, 0);
> #endif

Actually, this is wrong too, since it's a dma_addr_t, not an unsigned long, so:

#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
        src_writel(dev, MUnit.IQ_H, (address >> 32) & 0xffffffff);
#else
        src_writel(dev, MUnit.IQ_H, 0);
#endif



> I'm assuming the compiler can optimize line 426 to skip the masking in such a case.
> 
>> drivers/scsi/aacraid/src.c:425:
>>  422		if (address & (ALIGN32 - 1))
>>  423			return -EINVAL;
>>  424		address |= fibsize;
>>> 425		src_writel(dev, MUnit.IQ_H, (address >> 32) & 0xffffffff);
>>  426		src_writel(dev, MUnit.IQ_L, address & 0xffffffff);
>>  427	
>>  428		return 0;
>> 
>> ---
>> 0-DAY kernel build testing backend         Open Source Technology Centre
>> Fengguang Wu <wfg@xxxxxxxxxxxxxxx>                     Intel Corporation
>> <0001-SCSI-aacraid-Fix-endian-issues-in-core-and-SRC-porti.patch><src.c>
> 
> --
> Bluecherry: http://www.bluecherrydvr.com/
> SwissDisk : http://www.swissdisk.com/
> Ubuntu    : http://www.ubuntu.com/
> My Blog   : http://ben-collins.blogspot.com/
> 

--
Bluecherry: http://www.bluecherrydvr.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu    : http://www.ubuntu.com/
My Blog   : http://ben-collins.blogspot.com/

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html