Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk on usb hdd

[Sergei Shtylyov <sshtylyov@xxxxxxxxxx>]

Hello.

On 10-06-2012 4:30, Namjae Jeon wrote:

> > > Add support for write cache quirk on usb hdd. scsi driver will be set to
> > > wce
> > > by detecting write cache quirk in quirk list when plugging usb hdd.

> > > Signed-off-by: Namjae Jeon<namjae.jeon@xxxxxxxxxxx>
> > > Signed-off-by: Pankaj Kumar<pankaj.km@xxxxxxxxxxx>
> > > Signed-off-by: Amit Sahrawat<a.sahrawat@xxxxxxxxxxx>
> > > ---
> > >    drivers/usb/storage/scsiglue.c |    5 +++++
> > >    drivers/usb/storage/usb.c      |    5 ++++-
> > >    include/linux/usb_usual.h      |    4 +++-
> > >    3 files changed, 12 insertions(+), 2 deletions(-)

> > > diff --git a/drivers/usb/storage/scsiglue.c
> > > b/drivers/usb/storage/scsiglue.c
> > > index a324a5d..fe42547 100644
> > > --- a/drivers/usb/storage/scsiglue.c
> > > +++ b/drivers/usb/storage/scsiglue.c
> > [...]
> > > @@ -529,6 +529,9 @@ static void adjust_quirks(struct us_data *us)
> > >    		case 'o':
> > >    			f |= US_FL_CAPACITY_OK;
> > >    			break;
> > > +		case 'p':
> > > +			f |= US_FL_WRITE_CACHE;
> > > +			break;
> > >    		case 'r':
> > >    			f |= US_FL_IGNORE_RESIDUE;
> > >    			break;
> >
> >      You probably should unite this chunk with the documentation update
> > patch.

> Hi Sergei.
> I tried to post documentation update patch(4/4) for this chunk.
> Do I misunderstand ?

   I mean that the documenation should be updated in the same patch where you 
add the new value.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html