Re: scsi: lpfc_scsi: Remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Richard,

fyi - this error in lpfc was corrected in our 8.3.31 patch set - posted back in May:
http://www.spinics.net/lists/linux-scsi/msg59216.html

-- james


On 6/7/2012 2:42 AM, Jonathan Nieder wrote:
Richard Yao wrote:

Using -Werror enables us to catch potential runtime issues before they
happen.
You have more trust in GCC and other compilers than I do.

If you'd like some entertainment, then for example see:

  http://gcc.gnu.org/PR52798
  http://gcc.gnu.org/PR25509

Bugs and misdesigned features do not have to be involved for this to
be a problem --- all it takes is a gcc upgrade that adds a new
warning, and suddenly you've turned your existing potential code
cleanliness improvements into failed builds and lots of wasted time
for innocent sysadmins.  -Werror is great for development, but using
it in production turns out to be pretty much always a terrible idea.

Thanks for the chance to vent about this. :)  It's bad, bad, bad.

Ciao,
Jonathan

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux