Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk on usb hdd

Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> · Sun, 10 Jun 2012 13:36:53 -0400 (EDT)

On Sat, 9 Jun 2012, Namjae Jeon wrote:

> Add support for write cache quirk on usb hdd. scsi driver will be set to wce
> by detecting write cache quirk in quirk list when plugging usb hdd.

> --- a/include/linux/usb_usual.h
> +++ b/include/linux/usb_usual.h
> @@ -64,7 +64,9 @@
>  	US_FLAG(NO_READ_CAPACITY_16,	0x00080000)		\
>  		/* cannot handle READ_CAPACITY_16 */		\
>  	US_FLAG(INITIAL_READ10,	0x00100000)			\
> -		/* Initial READ(10) (and others) must be retried */
> +		/* Initial READ(10) (and others) must be retried */	\
> +	US_FLAG(WRITE_CACHE,	0x00200000)			\
> +		/* Write Cache status is not available */

The documentation for the new flag should be added in the same patch 
along with the flag itself.  There's no reason to have separate 
patches.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html