Re: scsi: lpfc_scsi: Remove unused variables

[Jonathan Nieder <jrnieder@xxxxxxxxx>]

Richard Yao wrote:

> Using -Werror enables us to catch potential runtime issues before they
> happen.

You have more trust in GCC and other compilers than I do.

If you'd like some entertainment, then for example see:

 http://gcc.gnu.org/PR52798
 http://gcc.gnu.org/PR25509

Bugs and misdesigned features do not have to be involved for this to
be a problem --- all it takes is a gcc upgrade that adds a new
warning, and suddenly you've turned your existing potential code
cleanliness improvements into failed builds and lots of wasted time
for innocent sysadmins.  -Werror is great for development, but using
it in production turns out to be pretty much always a terrible idea.

Thanks for the chance to vent about this. :)  It's bad, bad, bad.

Ciao,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html