Re: [PATCH 4/6] bnx2fc: Improve error recovery by handling parity errors

[James Bottomley <jbottomley@xxxxxxxxxxxxx>]

On Mon, 2012-06-04 at 16:15 -0700, Bhanu Prakash Gollapudi wrote:
> @@ -321,6 +332,9 @@ static void bnx2fc_upload_session(struct fcoe_port *port,
>  
>  		del_timer_sync(&tgt->upld_timer);
>  
> +	} else if (test_bit(BNX2FC_FLAG_DISABLE_FAILED, &tgt->flags))
> +		printk(KERN_ERR PFX "ERROR!! DISABLE req failed, destroy"
> +				" not sent to FW\n");
>  	} else
>  		printk(KERN_ERR PFX "ERROR!! DISABLE req timed out, destroy"
>  				" not sent to FW\n");

You didn't actually compile this did you?  That else if has to have an
opening brace to match the closing one on the next else ...

James

��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f