Re: [PATCH 1/4] block: Fix race on request_queue.end_io invocations

[Tejun Heo <tj@xxxxxxxxxx>]

On Tue, Jun 05, 2012 at 05:10:15PM +0000, Bart Van Assche wrote:
> Some request_queue.end_io implementations can be called safely
> without the queue lock held while several other implementations
> assume that the queue lock is held. So let's play it safe and
> make sure that the queue lock is held around end_io invocations.
> Found this through source code review.
> 
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Not sure about stable@ tho.  This doesn't fix any visible issue at the
moment and any change carries some risk.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html