Re: [PATCH] srp: convert SRP_RQ_SHIFT into a module parameter

[Bernd Schubert <bernd.schubert@xxxxxxxxxxx>]

> @@ -2131,9 +2171,15 @@ static ssize_t srp_create_target(struct device *dev,
>  	target_host->max_id      = 1;
>  	target_host->max_lun     = SRP_MAX_LUN;
>  	target_host->max_cmd_len = sizeof ((struct srp_cmd *) (void *) 0L)->cdb;
> +	target_host->can_queue   = srp_cmd_sq_size;
> +	target_host->cmd_per_lun = srp_cmd_sq_size;
>  
>  	target = host_to_target(target_host);
>  
> +	ret = srp_alloc_target_rings(target);
> +	if (ret)
> +		goto err;


Here is a memory leak if something fails below, I need to add another
goto target.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html