Re: [PATCH 1/4] SCSI: add new SDEV_TRANSPORT_OFFLINE state

[Hannes Reinecke <hare@xxxxxxx>]

On 05/18/2012 06:56 AM, michaelc@xxxxxxxxxxx wrote:
> From: Mike Christie <michaelc@xxxxxxxxxxx>
> 
> This patch adds a new state SDEV_TRANSPORT_OFFLINE. It will
> be used by transport classes to offline devices for cases like
> when the fast_io_fail/recovery_tmo fires. In those cases we
> want all IO to fail, and we have not yet escalated to dev_loss_tmo
> behavior where we are removing the devices.
> 
> Currently to handle this state, transport classes are setting
> the scsi_device's state to running, setting their internal
> session/port structs state to something that indicates failed,
> and then failing IO from some transport check in the queuecommand.
> 
> The reason for the new value is so that users can distinguish
> between a device failure that is a result of a transport problem
> vs the wide range of errors that devices get offlined for
> when a scsi command times out and we offline the devices there.
> It also fixes the confusion as to why the transport class is
> failing IO, but has set the device state from blocked to running.
> 
Very neat.

Acked-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html