Re: [PATCH] qla_target: Check refcount in find_sess_by_*

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Fri, 2012-05-18 at 18:49 -0400, Jörn Engel wrote:
> On Thu, 17 May 2012 23:09:27 -0700, Nicholas A. Bellinger wrote:
> > 
> > So that means your testing with it now, right..?
> 
> Our kernel has diverged too much from yours to easily move patches
> back and forth, so no.
> 
> But more importantly, we still don't have a complete patchset.
> 

Ok, I've pushed into lio-core the following WIP patches based on your
original patch + s_id + loop_id clearing patch from today:

6fc162d3 tcm_qla2xxx: Clear session s_id + loop_id earlier during shutdown
dfebe3b5 tcm_qla2xxx: Convert to TFO->put_session() usage
ec7cf009 target: Add TFO->put_session() caller for HW fabric session shutdown

Today I've been testing these changes against typical active I/O during
tcm_qla2xxx endpoint shutdown, and against explict NodeACL + MappedLUNs
removal case.  So far with active FCP of the order of ~100K IOPs with
random mixed mode 4K blocks, these patches are performing session
shutdown and unloading tcm_qla2xxx references as expected.

Certainly these need more testing wrt to a number of special cases for
active I/O shutdown, but I think they look reasonable enough to put into
lio-core for now..

Please have a look and let me know if you have any problems getting it
applied for testing into your .39 tree.

Thanks,

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html