Re: [PATCH 5/6] qla4xxx: Capture minidump for ISP82XX on firmware failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, 2012-04-27 at 11:05 -0500, Mike Christie wrote:
> On 04/24/2012 12:32 AM, vikas.chaudhary@xxxxxxxxxx wrote:
> > +
> > +static ssize_t
> > +qla4_8xxx_sysfs_write_fw_dump(struct file *filep, struct kobject *kobj,
> > +			      struct bin_attribute *ba, char *buf, loff_t off,
> > +			      size_t count)
> > +{
> > +	struct scsi_qla_host *ha = to_qla_host(dev_to_shost(container_of(kobj,
> > +					       struct device, kobj)));
> > +	uint32_t dev_state;
> > +	int reading;
> > +
> > +	if (!is_qla8022(ha))
> > +		return -EINVAL;
> > +
> > +	if (off != 0)
> > +		return 0;
> > +
> > +	reading = simple_strtol(buf, NULL, 10);
> 
> I think we are supposed to be using kstrtol now.

We are.  Checkpatch even warns about this, please fix.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux