Re: [patch] target: lock => unlock typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, 2012-05-08 at 13:28 +0300, Dan Carpenter wrote:
> target_stop_cmd() returns with the lock held and IRQs disabled.  The
> intent was to unlock here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 0d838ab..8bd9ffe 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -3769,7 +3769,7 @@ static int transport_lun_wait_for_tasks(struct se_cmd *cmd, struct se_lun *lun)
>  	    (cmd->transport_state & CMD_T_SENT)) {
>  		if (!target_stop_cmd(cmd, &flags))
>  			ret++;
> -		spin_lock_irqsave(&cmd->t_state_lock, flags);
> +		spin_unlock_irqrestore(&cmd->t_state_lock, flags);
>  	} else {
>  		spin_unlock_irqrestore(&cmd->t_state_lock,
>  				flags);
> --

Applied to lio-core, and folding into hch's original commit that
introduced the bug in for-next.

Thanks Dan!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux