Re: [PATCH 4/6] qla4xxx: Add change_queue_depth API support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

-----Original Message-----
From: Mike Christie <michaelc@xxxxxxxxxxx>
Date: Fri, 27 Apr 2012 08:43:15 -0700
To: Vikas <vikas.chaudhary@xxxxxxxxxx>
Cc: "jbottomley@xxxxxxxxxxxxx" <jbottomley@xxxxxxxxxxxxx>, scsi
<linux-scsi@xxxxxxxxxxxxxxx>, Lalit Chandivade
<lalit.chandivade@xxxxxxxxxx>, Ravi Anand <ravi.anand@xxxxxxxxxx>, Tej
Parkash <tej.parkash@xxxxxxxxxx>
Subject: Re: [PATCH 4/6] qla4xxx: Add change_queue_depth API support

>On 04/24/2012 12:32 AM, vikas.chaudhary@xxxxxxxxxx wrote:
>> +static int qla4xxx_change_queue_depth(struct scsi_device *sdev, int
>> +                                  int reason)
>> +{
>> +    int queue_depth;
>> +    if (!ql4xqfulltracking)
>> +            return -EOPNOTSUPP;
>> +
>> +    queue_depth = iscsi_change_queue_depth(sdev, qdepth, reason);
>> +    return queue_depth;
>> +}
>> +
>No need for queue_depth. Just do
>return iscsi_change_queue_depth(sdev, qdepth, reason);

Thanks for the review.
updated patch is posted here:

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux