Re: [PATCH 10/11] qla4xxx: Added ping support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 02/13/2012 07:00 AM, vikas.chaudhary@xxxxxxxxxx wrote:
> +
> +		if (mbox_sts_entry->out_mbox[0] == MBOX_STS_COMMAND_COMPLETE)
> +			status = QLA_SUCCESS;
> +		else
> +			status = QLA_ERROR;
> +
> +		data_size = sizeof(mbox_sts_entry->out_mbox);
> +
> +		qla4xxx_post_ping_evt_work(ha, status, mrb->pid, data_size,
> +					(uint8_t *) mbox_sts_entry->out_mbox);
> +		break;
> +

Not sure what I was thinking. This is not going to work.

We are not going to pass back vendor specific values, and then have
multiple decoders in userspace.

What are you trying to pass back up to userspace? Can you add a enum or
defines for some common error values? We can also pass back vendor
specific info, but we have to also have some common error cls info or it
is completely useless to other apps.

And, can we get more info that if it failed or not?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux