- To: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>
- Subject: [PATCH 1/3] mm: Wait for writeback when grabbing pages to begin a write
- From: "Darrick J. Wong" <djwong@xxxxxxxxxx>
- Date: Thu, 19 May 2011 15:48:49 -0700
- Cc: Jens Axboe <axboe@xxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, Chris Mason <chris.mason@xxxxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Mingming Cao <mcao@xxxxxxxxxx>
- In-reply-to: <20110519224841.28755.80650.stgit@xxxxxxxxxxxxxxxxxxxxxxxxx>
- User-agent: StGit/0.15
When grabbing a page for a buffered IO write, the mm should wait for writeback
on the page to complete so that the page does not become writable during the IO
operation. This change is needed to provide page stability during writes for
all filesystems.
Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
---
mm/filemap.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index c641edf..fd0e7f2 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2288,7 +2288,7 @@ struct page *grab_cache_page_write_begin(struct address_space *mapping,
repeat:
page = find_lock_page(mapping, index);
if (page)
- return page;
+ goto found;
page = __page_cache_alloc(mapping_gfp_mask(mapping) & ~gfp_notmask);
if (!page)
@@ -2301,6 +2301,8 @@ repeat:
goto repeat;
return NULL;
}
+found:
+ wait_on_page_writeback(page);
return page;
}
EXPORT_SYMBOL(grab_cache_page_write_begin);
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[SCSI Target Devel]
[Linux SCSI Target Infrastructure]
[Kernel Newbies]
[Share Photos]
[IDE]
[Security]
[Git]
[Netfilter]
[Bugtraq]
[Photos]
[Yosemite]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Linux ATA RAID]
[Linux IIO]
[Samba]
[Video 4 Linux]
[Device Mapper]
[Linux Resources]