Re: [PATCH] scsi: Disable advansys on ARM and MIPS

[Martin Michlmayr <tbm@xxxxxxxxxx>]

* Matthew Wilcox <matthew@xxxxxx> [2008-09-30 10:13]:
> > Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
> > work on parisc") removed the "depends on BROKEN || X86_32" line from
> > advansys' Kconfig entry.  Unfortunately, this led to compilation errors
> > on ARM and MIPS (that are not related).  Since nobody looked into this
> > issue since I reported it in January 2008 and Russell King said that
> > the driver is completely broken on ARM, let's undo some of the damage
> > caused by the removal of the "BROKEN" Kconfig depends by disabling the
> > driver on ARM and MIPS.
> 
> Huh?  I've looked into it.  ARM and MIPS provide half of an API but not
> the other half.  These architectures are broken.

Maybe, but the point is that advansys was marked as BROKEN on !X86_32
before and now it's not, so the ARM/MIPS compilation errors show up
and that's a regression.  What you say is a good argument for my patch
to disable advansys for ARM/MIPS in Kconfig.

-- 
Martin Michlmayr
http://www.cyrius.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html