Re: [PATCH 6/7] scsi_dh: Update RDAC device handler

[Chandra Seetharaman <sekharan@xxxxxxxxxx>]

On Thu, 2008-05-15 at 11:02 +0200, Hannes Reinecke wrote:
<snip>

> >> @@ -478,24 +491,9 @@ static int rdac_activate(struct scsi_device *sdev)
> >>  	struct rdac_dh_data *h = get_rdac_data(sdev);
> >>  	int err = SCSI_DH_OK;
> >>
> >> -	if (h->lun == UNINITIALIZED_LUN) {
> >> -		err = get_lun(sdev);
> >> -		if (err != SCSI_DH_OK)
> >> -			goto done;
> >> -	}
> >> -
> >>  	err = check_ownership(sdev);
> >> -	switch (err) {
> >> -	case RDAC_UNOWNED:
> >> -		break;
> >> -	case RDAC_OWNED:
> >> -		err = SCSI_DH_OK;
> >> -		goto done;
> >> -	case RDAC_FAILED:
> >> -	default:
> >> -		err = SCSI_DH_IO;
> > 
> > What does this change yield ? (under check_ownership)
> > 
> We're now setting the lun state explicitly, so there's
> no need to return different error codes.

That is my question. what did we gain by the addition of lun_state ?


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html