Re: [PATCH 4/7] scsi_dh: Update EMC handler

[Chandra Seetharaman <sekharan@xxxxxxxxxx>]

On Thu, 2008-05-15 at 10:09 +0200, Hannes Reinecke wrote:
> Hi Chandra,
> 
> Chandra Seetharaman wrote:
> > On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote:
> > <snip>
> > 
> >> @@ -438,10 +604,32 @@ static int clariion_bus_attach(struct scsi_device *sdev)
> >>  	sdev->scsi_dh_data = scsi_dh_data;
> >>  	spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
> >>
> > Can move the block above to be just before try_module_get() and avoid
> > undoing it in the failed path.
> > 
> Hmm. Yes, we could. But that means I have to pass the scsi_dh_data structure
> to basically every function.
> Let me check how this pans out.

Yeah, it is a catch-22 problem. I will think about it too.

> 
> Cheers,
> 
> Hannes

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html