Re: [PATCH 5/7] scsi_dh: Update hp_sw hardware handler

[Chandra Seetharaman <sekharan@xxxxxxxxxx>]

No need for blk_put_request() as noted in an earlier patch.

On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote:

<snip>
>  	spin_lock_irqsave(sdev->request_queue->queue_lock, flags);
>  	sdev->scsi_dh_data = scsi_dh_data;
>  	spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);

we can move this below the initializations.
> +
> +	ret = hp_sw_tur(sdev);
> +	if (ret != SCSI_DH_OK || h->path_state == HP_SW_PATH_UNINITIALIZED)
> +		goto failed;
> +
> +	sdev_printk(KERN_INFO, sdev, "%s: %s path\n",
> +		    HP_SW_NAME, h->path_state == HP_SW_PATH_ACTIVE?
> +		    "active":"passive");
> +

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html