RE: [PATCH v4 05/12] ARM: EXYNOS: add support uart for EXYNOS4 and EXYNOS5

[Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>]

Hello,

On Wednesday, March 21, 2012 10:14 AM Thomas Abraham wrote:

> On 14 March 2012 20:12, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> > Actually, the base address of uart is different between EXYNOS4
> > and EXYNOS5 and this patch enables to support uart for EXYNOS4
> > and EXYNOS5 SoCs at runtime.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> > ---
> 
> [...]
> 
> > diff --git a/arch/arm/mach-exynos/include/mach/debug-macro.S b/arch/arm/mach-
> exynos/include/mach/debug-macro.S
> > index 6cacf16..6c857ff 100644
> > --- a/arch/arm/mach-exynos/include/mach/debug-macro.S
> > +++ b/arch/arm/mach-exynos/include/mach/debug-macro.S
> > @@ -21,8 +21,13 @@
> >         */
> >
> >        .macro addruart, rp, rv, tmp
> > -               ldr     \rp, = S3C_PA_UART
> > -               ldr     \rv, = S3C_VA_UART
> > +               mov     \rp, #0x10000000
> 
> This is physical address of Exynos4/5 CPUID register which cannot be
> used here. And virtual address S5P_VA_CPUID also cannot be used here
> since this will be called before paging_init when earlyprintk boot
> param is used. So, with this change, earlyprintk does not work for
> both Exynos4 and Exynos5.

I confirm, printascii freeze the system on EXYNOS4 after that patch,
tested on Exynos4210 Nuri board.

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html