Re: [GIT PULL] Samsung Cleanup EXYNOS clock for v3.4
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 03/08/12 07:16, Olof Johansson wrote:
Hi, On Thu, Mar 8, 2012 at 3:13 AM, Kukjin Kim<kgene.kim@xxxxxxxxxxx> wrote:Kukjin Kim (2): ARM: EXYNOS: cleanup clock part for new EXYNOS SoCsThis is one large commit that does many things in one change. As the patch message says: ARM: EXYNOS: cleanup clock part for new EXYNOS SoCs - the prefix of clk register replace S5P_ with EXYNOS4_ - move mach-exynos/clock.c to mach-exynos/clock-exynos4.c - according to moving clock-exynos4.c, move<mach/exynos4-clock.h> to "clock-exynos4.h" - add prefix exynos4_ on clk declaration It makes it hard to review, especially when you combine a move with other changes. It's better to do the move in a separate commit that doesn't change code (or only changes very very little) and then do the other changes in separate commits later.
Hmm...OK, let me do as per your suggestion and will re-send this soon. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html