Re: [PATCH v3 0/4] mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Wed, Mar 07, 2012 at 12:03:31PM +0900, Jaehoon Chung wrote:
> On 03/07/2012 01:30 AM, Mark Brown wrote:

> > The same IP is present and used with the same driver on other Samsung
> > SoCs.

> I know that used with the same driver on other Samsung-SoCs(S3C64XX/S3C24XX..etc)
> I just only used the interface in sdhci-pltfm.c. Nothing difference..
> Why do you think that will break the other SoC?

> Header file(/plat/regs-sdhci.h) also is only used in sdhci-s3c.c.
> And the least portion is moved into /linux/mmc/. 
> Then included "linux/mmc/sdhci-s3c.h" in plat/sdhci.h.

> What's difference? 
> If you can explain the more detail, i can understand.
> But sorry, now i didn't accept your opinion.

To be honest I didn't read the series, the diffstat looks so obviously
problematic as you're touching the setup-gpio- files for only a subset
of Samsung architectures - there's been quite regular issues with
updates for newer SoCs breaking support for s3c64xx.

I also notice that this will conflict with the series I've previously
posted for runtime PM support which would push us even further back from
being able to use the lower power WFI modes in mainline :(  Though
hopefully that'll be easier to fix.

Attachment: signature.asc
Description: Digital signature

[Home]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [PDAs]     [Free Online Dating]     [Hacking TiVo]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Big List of Linux Books]     [16.7MP]

Add to Google Powered by Linux