Re: s390-tools: zipl build fails with binutils-2.21+ on s390

[Martin Schwidefsky <schwidefsky@xxxxxxxxxx>]

On Mon, 5 Dec 2011 02:47:24 -0500
Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> after upgrading our s390 systems (-m31) to binutils-2.21.1, we noticed the 
> s390-tools package failed in the zipl code:
> 
> gcc -O2 -pipe -W -Wall -Wno-unused-parameter  -W -Wall -Wno-unused-parameter  
> -W -Wall -Wno-unused-parameter  -DS390_TOOLS_RELEASE=1.15.0-build-20111205 -
> DS390_TOOLS_LIBDIR=/lib/s390-tools -DS390_TOOLS_SYSCONFDIR=/etc -
> DS390_TOOLS_RELEASE=1.15.0-build-20111205 -DS390_TOOLS_LIBDIR=/lib/s390-tools 
> -DS390_TOOLS_SYSCONFDIR=/etc -DS390_TOOLS_RELEASE=1.15.0-build-20111205 -
> DS390_TOOLS_LIBDIR=/lib/s390-tools -DS390_TOOLS_SYSCONFDIR=/etc -I../include -
> D__ASSEMBLY__ -
> DS390_TOOLS_VERSION_EBCDIC=0xf1,0x4b,0xf1,0xf5,0x4b,0xf0,0x60,0x82,0xa4,0x89,0x93,0x84,0x60,0xf2,0xf0,0xf1,0xf1,0xf1,0xf2,0xf0,0xf5 
> -c -o eckd2dump.o eckd2dump.S
> eckd2dump.S: Assembler messages:
> eckd2dump.S:708: Error: Unrecognized opcode: `larl'
> eckd2dump.S:708: Error: Unrecognized opcode: `larl'
> make[2]: *** [eckd2dump.o] Error 1
> 
> Debian fixed this by adding -m64 to CFLAGS in zipl's boot/Makefile.  is this the 
> right way to go ?  if so, could we get this added to the s390-tools package ?

No, the bug is in dumpcommon.S where the 31 bit code section uses larl. That is not
a good idea as this instruction is not available on old machines (pre z900).

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Attachment: signature.asc
Description: PGP signature