RE: [PATCH][UPSTREAM]net,RT:Remove preemption disabling in netif_rx()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
On Thu, 2012-05-24 at 04:28 +0000, Jain Priyanka-B32167 wrote:
> Waiting for review comments on this.
>
> diff --git a/net/core/dev.c b/net/core/dev.c index 452db70..4017820 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2940,7 +2940,7 @@ int netif_rx(struct sk_buff *skb)
> struct rps_dev_flow voidflow, *rflow = &voidflow;
> int cpu;
>
> - preempt_disable();
> + migrate_disable();
I really want to avoid placing open coded migrate_disable() around the
kernel. Perhaps we should use "get_cpu_light()" here too.
-- Steve
> rcu_read_lock();
>
> cpu = get_rps_cpu(skb->dev, skb, &rflow); @@ -2950,13 +2950,13 @@ int netif_rx(struct sk_buff *skb)
> ret = enqueue_to_backlog(skb, cpu, &rflow->last_qtail);
>
> rcu_read_unlock();
> - preempt_enable();
> + migrate_enable();
> } else
> #endif
> {
> unsigned int qtail;
> - ret = enqueue_to_backlog(skb, get_cpu(), &qtail);
> - put_cpu();
> + ret = enqueue_to_backlog(skb, get_cpu_light(), &qtail);
> + put_cpu_light();
> }
> return ret;
> }
> --
> 1.7.4.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RT Stable]
[Kernel Newbies]
[Share Photos]
[IDE]
[Security]
[Git]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Linux ATA RAID]
[Samba]
[Video 4 Linux]
[Device Mapper]
[Linux Resources]