Re: [PATCH 1/3] rt-tests: Support user supplied CFLAGS and LDFLAGS

[Darren Hart <dvhart@xxxxxxxxxxxxxxx>]

On 03/20/2012 12:31 PM, Remy Bohmer wrote:
> Hi,
> 
> 2012/3/20 Darren Hart <dvhart@xxxxxxxxxxxxxxx>:
>> Accept user supplied CFLAGS and LDFLAGS, overwriting the
>> Makefile supplied versions. This can cause the build to
>> fail if the user does not provide at least what the Makefile
>> defines, but so be it.
>> -CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
>> +CFLAGS ?= -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
>> +LDFLAGS ?=
> 
> Why not append the Makefile local flags to the user supplied flags?
> Something like:
> CFLAGS := $(CFLAGS) -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
> 

I considered that. Ultimately, the goal is to provide more control to
users, especially those who may be integrating the package into a larger
build system. In this case, I think control of which warnings you
display and where the includes come from should be configurable, even if
it enables them to blow their feet off.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html