Re: [PATCH net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Steve Wise" <swise@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 27 Feb 2014 11:11:49 -0600

>> 
>> > -static int allow_db_fc_on_t5;
>> > -module_param(allow_db_fc_on_t5, int, 0644);
>> > -MODULE_PARM_DESC(allow_db_fc_on_t5,
>> > -		 "Allow DB Flow Control on T5 (default = 0)");
>> > -
>> > -static int allow_db_coalescing_on_t5;
>> > -module_param(allow_db_coalescing_on_t5, int, 0644);
>> > -MODULE_PARM_DESC(allow_db_coalescing_on_t5,
>> > -		 "Allow DB Coalescing on T5 (default = 0)");
>> 
>> Module parameters are a user facing interface.
>> 
>> You cannot just delete, or change the semantics of, the ones you feel
>> like doing so to.
> 
> I see your point on user facing interfaces.   These module params were
> added initially to allow tweaking the db drop recovery for T5 devices in
> the thought that we might need it.  It turns out T5 doesn't suffer from
> this issue.  These params default to 0 anyway, and I doubt anyone has
> changed them.  Disabling the hw db coalescing feature proved problematic
> and it turned out to even make the issue worse, so I removed it totally
> at the recommendation from the HW engineers, and put in place the new
> design which better rate controls things under heavy load.

You have to keep the old ones around.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux