On 02/19/2014 11:54 AM, Yann Droneaud wrote: > Le mercredi 19 février 2014 à 17:47 +0100, Yann Droneaud a écrit : >> Le mercredi 19 février 2014 à 09:55 -0500, Prarit Bhargava a écrit : >>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’: >>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized] >>> status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps); >>> >>> ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps >>> so it doesn't need to be passed on. Removing the variable results in the >>> warning going away. >>> >> >> Nice to see this warning removed. >> >>> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx> >>> >> >> You should move the signed of after the Cc's. >> >>> Cc: Roland Dreier <roland@xxxxxxxxxx> >>> Cc: Sean Hefty <sean.hefty@xxxxxxxxx> >>> Cc: Hal Rosenstock <hal.rosenstock@xxxxxxxxx> >>> Cc: Naresh Gottumukkala <bgottumukkala@xxxxxxxxxx> >>> Cc: Moni Shoua <monis@xxxxxxxxxxxx> >>> Or Gerlitz <ogerlitz@xxxxxxxxxxxx> >> ^^^ >> There's a missing Cc: tag Oops. I'll add him to v2. >> >>> Cc: Matan Barak <matanb@xxxxxxxxxxxx> >>> Cc: "Gottumukkala, Naresh" <B.A.L.NRaju.Gottumukkala@xxxxxxxxxx> >> > > Additionnaly some addresses seems to be invalid: > > <B.A.L.NRaju.Gottumukkala@xxxxxxxxxx>: host > emulex.com.mail5.psmtp.com[64.18.5.10] said: 550 No such user - psmtp > (in reply to RCPT TO command) > > <bgottumukkala@xxxxxxxxxx>: host emulex.com.mail5.psmtp.com[64.18.5.10] > said: 550 No such user - psmtp (in reply to RCPT TO command) Yep, but those are spit out by get_maintainer.pl before I send the patch. There's no way to know that they are dead email addresses until the mail is sent :/. Trimming them now... P. > > Regards. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html