Re: IB/srp: merge fixes from MLNX_OFED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/18/2014 7:05 PM, Bart Van Assche wrote:
On 02/18/14 17:47, Sebastian Riemer wrote:
I've also noticed the added target locking around target->free_tx
handling in srp_rport_reconnect(). There are cases e.g. in
srp_queuecommand() where holding the rport mutex isn't enough to protect
it. So for me this looks right.

Then, in srp_create_target() I've noticed the check of the return value
of ib_query_gid(). Makes completely sense to check it.

Please send patches for so obvious fixes to the mailing list! There is a
very good chance that they get accepted.
Hello Sebastian,

If I hadn't been busy testing scsi-mq patches recently, the SRP
initiator patches you referred to would already have been posted for
review on the linux-rdma mailing list. I hope to find some time one of
the next days to post a few SRP initiator patches on the linux-rdma
mailing list - not only the ones referred to above but also a few other
patches.

Hey Sebastian & Bart,

Yes, I did plan to submit a few patches for SRP soon (I'm currently busy playing with scsi-mq and cleaning-up iSER DIF patches).
Thanks for the reminder, you are absolutely right!

Regarding the FMR unmap crash, I experienced it when running our distro-backported MLNX_OFED and hadn't got a chance to see if it reproduces in upstream yet. Thanks for confirming this reproduces here as well. Bart, Are you familiar with this issue? it should reproduce over mlx5 driver or SRIOV (where FMRs are not supported).

Regarding the rest,
Let's let Bart propose his fixes and I'll make sure to see if I have anything to add there.

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux