Re: [PATCH] {NET,IB}/mlx4: 64 byte CQE/EQE support

[Roland Dreier <roland@xxxxxxxxxx>]

On Tue, May 29, 2012 at 7:41 AM, Or Gerlitz <ogerlitz@xxxxxxxxxxxx> wrote:
> Jack is now fixing that with the SRIOV IB patches he's working on,
> so please hold off with accepting this patch. I would still love to get
> feedback on
> the design re user space, etc compatibility and the patch in general.

OK, I'll hold off for now.

In general I'm kind of sad about the way the hardware works: having
to choose the incompatible 64-byte CQE format globally at startup
means we're kind of stuck breaking userspace in some cases.

I would suggest that we merge the fixed version of this into 3.6 with the
default to be compatible, 32-byte CQEs in all cases, and make sure
the 64-byte CQE handling is available in a libmlx4 release before then
(if you send me the change for that I'm happy to make a quick release).

Then around 3.8 or so we can have the kernel default to 64-byte CQEs
for HW that supports it.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html