Re: [PATCH 1/5] infiniband-diags/ibroute.c: Dead code removal

[Ira Weiny <weiny2@xxxxxxxx>]

On Thu, 12 Apr 2012 18:09:41 -0700
Jim Foraker <foraker1@xxxxxxxx> wrote:

> Program has already exited in the case where argc == 0
> 
> Signed-off-by: Jim Foraker <foraker1@xxxxxxxx>

Thanks applied,
Ira

> ---
>  src/ibroute.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/ibroute.c b/src/ibroute.c
> index 7339218..1bf1fb0 100644
> --- a/src/ibroute.c
> +++ b/src/ibroute.c
> @@ -432,10 +432,7 @@ int main(int argc, char **argv)
>  	if (!srcport)
>  		IBERROR("Failed to open '%s' port '%d'", ibd_ca, ibd_ca_port);
>  
> -	if (!argc) {
> -		if (ib_resolve_self_via(&portid, 0, 0, srcport) < 0)
> -			IBERROR("can't resolve self addr");
> -	} else if (ib_resolve_portid_str_via(&portid, argv[0], ibd_dest_type,
> +	if (ib_resolve_portid_str_via(&portid, argv[0], ibd_dest_type,
>  					     ibd_sm_id, srcport) < 0)
>  		IBERROR("can't resolve destination port %s", argv[1]);
>  
> -- 
> 1.7.9.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
weiny2@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html