Re: [PATCH 2/2] IB/core: add missing string for the display of SDR rates in sysfs

[Or Gerlitz <or.gerlitz@xxxxxxxxx>]

On Mon, Apr 2, 2012 at 8:42 PM, Roland Dreier <roland@xxxxxxxxxx> wrote:
>
> On Mon, Apr 2, 2012 at 7:45 AM, Or Gerlitz <ogerlitz@xxxxxxxxxxxx> wrote:
> >        switch (attr.active_speed) {
> >        case IB_SPEED_SDR:
> > +               speed = " SDR";
> >                rate = 25;
> >                break;
> >        case IB_SPEED_DDR:
>
> I don't think we want this -- old kernels didn't print "SDR" so I think
> we shouldn't change the interface at this point.

In other words, you want this fix for 3.5 and not 3.4 as this being
non-regression? its obviously a fix, since for SDR you just see emtpy
string.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html