Re: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Le lundi 30 janvier 2012 à 19:18 +1100, Herbert Xu a écrit :
> On Mon, Jan 30, 2012 at 09:04:32AM +0100, Eric Dumazet wrote:
> >
> > Hmm, do we really need to compare ether header, thats the question.
> 
> I think we do.  As otherwise macvlan would break.
> 

Thats the theory yes, but practically ?

Really, GRO can merge two TCP frames given they match everything needed,
exactly as our TCP stack would do in the end.

What could be a normal workload where this mismatch of two different tcp
flows could happen with macvlan or any kind of devices ?

If this is an attack, TCP will merge the frames anyway on the same
socket.

Or should we add checks in TCP stack, in case GRO is off ?



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Home]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]

Add to Google Powered by Linux