Re: idr_get_new_exact ?
- To: Paul Mundt <lethal@xxxxxxxxxxxx>
- Subject: Re: idr_get_new_exact ?
- From: Tejun Heo <htejun@xxxxxxxxx>
- Date: Thu, 23 Sep 2010 13:46:29 +0200
- Cc: Roland Dreier <rdreier@xxxxxxxxx>, Ohad Ben-Cohen <ohad@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Jean Delvare (PC drivers, core)" <khali@xxxxxxxxxxxx>, "Ben Dooks (embedded platforms)" <ben-linux@xxxxxxxxx>, Roland Dreier <rolandd@xxxxxxxxx>, Sean Hefty <sean.hefty@xxxxxxxxx>, Hal Rosenstock <hal.rosenstock@xxxxxxxxx>, Steve Wise <swise@xxxxxxxxxxx>, Neil Brown <neilb@xxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linux-i2c@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-ppp@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Alasdair G Kergon <agk@xxxxxxxxxx>
- In-reply-to: <20100923114255.GB27960@xxxxxxxxxxxx>
- User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.9) Gecko/20100915 Lightning/1.0b2 Thunderbird/3.1.4
Hello,
On 09/23/2010 01:42 PM, Paul Mundt wrote:
> On Mon, Sep 20, 2010 at 11:26:47PM +0200, Tejun Heo wrote:
>> Hello,
>>
>> On 09/20/2010 10:35 PM, Roland Dreier wrote:
>>> Looks fine to me as an improvement over the status quo, but I wonder how
>>> many of these places could use the radix_tree stuff instead? If you're
>>> not using the ability of the idr code to assign an id for you, then it
>>> seems the radix_tree API is a better fit.
>>
>> I agree. Wouldn't those users better off simply using radix tree?
>>
> It could go either way. I was about to write the same function when
> playing with it for IRQ mapping, the idea being to propagate the initial
> tree with sparse static vectors and then switch over to dynamic IDs for
> virtual IRQ creation. I ended up going with a radix tree for other
> reasons, though.
I see. If there are use cases where fixed and dynamic IDs need to be
mixed, no objection from me.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Audio Users]
[Hams]
[Kernel Newbies]
[Security]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite Photos]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Samba]
[Video 4 Linux]
[Linux Resources]
[Fedora Users]