|
|
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] |
From: Dan Carpenter <error27@xxxxxxxxx> Date: Fri, 10 Sep 2010 13:58:10 +0200 > Smatch complains because we check whether "pch->chan" is NULL and then > dereference it unconditionally on the next line. Partly the reason this > bug was introduced is because code was too complicated. I've simplified > it a little. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > --- > Compile tested only. Perhaps it would be better to set pch->speed to > zero? The comments say that zero implies the speed hasn't been set. I think how you've fixed it is OK, actually this whole MP rewrite could use some more auditing :-) Applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html