Re: NOHZ: local_softirq_pending 08
- To: Tilman Schmidt <tilman@xxxxxxx>
- Subject: Re: NOHZ: local_softirq_pending 08
- From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
- Date: Fri, 23 Oct 2009 15:34:29 +0200
- Cc: Jarek Poplawski <jarkao2@xxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, hidave.darkstar@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, linux-ppp@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, paulus@xxxxxxxxx, isdn4linux <isdn4linux@xxxxxxxxxxxxxxxxxxxxxx>, i4ldeveloper <i4ldeveloper@xxxxxxxxxxxxxxxxxxxxxx>, Karsten Keil <isdn@xxxxxxxxxxxxxx>
- In-reply-to: <4AE0ECCE.2020407@xxxxxxx>
On Fri, 2009-10-23 at 01:37 +0200, Tilman Schmidt wrote:
> --- a/drivers/isdn/i4l/isdn_ppp.c
> +++ b/drivers/isdn/i4l/isdn_ppp.c
> @@ -1174,7 +1174,10 @@ isdn_ppp_push_higher(isdn_net_dev * net_dev, isdn_net_local * lp, struct sk_buff
> #endif /* CONFIG_IPPP_FILTER */
> skb->dev = dev;
> skb_reset_mac_header(skb);
> - netif_rx(skb);
> + if (in_interrupt())
> + netif_rx(skb);
> + else
> + netif_rx_ni(skb);
So you've verified that the entire i4l stack can cope with being called
twice on the same CPU, from different contexts?
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
[Linux Audio Users]
[Hams]
[Kernel Newbies]
[Security]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite Photos]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Samba]
[Video 4 Linux]
[Linux Resources]
[Fedora Users]