Re: [PATCH-RFC 07/10] parisc: switch to GENERIC_PCI_IOMAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sun, 2011-12-04 at 12:48 +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 24, 2011 at 10:19:34PM +0200, Michael S. Tsirkin wrote:
> > parisc copied pci_iomap from generic code, probably to avoid
> > pulling the rest of iomap.c in.  Since that's in
> > a separate file now, we can reuse the common implementation.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> 
> Sorry to nag, any ACKs/NACKs on the parisc part?
> I intend to send this to Linus if there are no
> objections. Thanks!

Next time, send the patch to linux-arch or linux-parisc ... it helps to
get people to review it.  Although this one looks completely trivial,
unless I'm missing something?

Obviously there was a bit of a brain fart when this was done: the parisc
piece shouldn't be a copy of the generic code: we don't have native i/o
ports and emulation is pretty expensive, so we should prefer
IORESOURCE_MEM over IORESOURCE_IO when both are available  ... but even
on x86, memory mapping is faster (although not by the order of magnitude
it is on parisc), so it looks like you could fix this in the generic
code.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux